Skip to content
Snippets Groups Projects

Draft: cast_volume: add an option to apply percentiles only on positive values.

Closed payno requested to merge fix_446 into master

The initial goal of this PR was to ignore (on user request) negative values when computing percentiles during volume-cast.

But it turned out there was some scores here and there that should be fixed on this PR.

It also intend to generalize PartialHistogram for any type of volume (defined in tomoscan at least). this is why the signature of PartialHistogram has been changed to work on a volume instead of an HDF5 url.

At the end it is sadly way more complex than expected. @paleo if you want we can have a look together might be simpler.

TODO

  • add option to compute percentiles on positive value only
  • rework VolumeHistogram to generalize it for any tomoscan volume
  • add test
  • add documentation

close #446

Signed-off-by: payno henri.payno@esrf.fr

Edited by payno

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • payno added 1 commit

    added 1 commit

    • a5922ebd - Fix get_histogram_single_volume: better handling of the case where the...

    Compare with previous version

  • Pierre Paleo mentioned in merge request !390 (merged)

    mentioned in merge request !390 (merged)

  • payno added 1 commit

    added 1 commit

    • 4ee20ae8 - histogram: look to open histogram file only if exists

    Compare with previous version

  • payno added 1 commit

    added 1 commit

    • 41bad6c7 - histogram: fix volume data_path

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading