Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • N Nabu
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 68
    • Issues 68
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • tomotools
  • Nabu
  • Merge requests
  • !72

Histogram computation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Pierre Paleo requested to merge histogram into master Sep 07, 2020
  • Overview 2
  • Commits 24
  • Pipelines 18
  • Changes 11

For converting the whole volume to uint16, a histogram is needed to get min/max/percentiles.

This PR adds a utility for computing histogram chunk by chunk. The final histogram is obtained by "merging" together the partial histograms. The result is slightly less accurate than computing the histogram directly on the whole volume, but the error is negligible if things are done properly.

To do

  • Class PartialHistogram
  • Unit test
  • Integrate in configuration
  • Pipeline: integrate histogram process
  • Pipeline: write NXProcess
  • Test on "bamboo" and "big"

Things to improve

  • This feature is available only for HDF5 output (#170 (closed))
  • process_name is hardcoded in most places (fullfield.py, local_reconstruction.py). This will be problematic when the process name will be associated with an "ID" (#169 (closed))
  • histogram is computed with numpy.histogram, which is relatively slow. For now it does the job, but we might consider implementing a faster version if needed (#172 (closed))
Edited Sep 10, 2020 by Pierre Paleo
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: histogram