cor estimator: add an option to skip flatfield

details

estimated_cor fails to find the CoR on a .nx that contains no dark/flats frames. the do_flatfield is indeed not handled.

close #568 (closed)

assigned to @payno

added 1 commit

• 095a0081 - cor estimator: add an option to skip flatfield

Compare with previous version

added 1 commit

• f7e3837c - cor estimator: add an option to skip flatfield

Compare with previous version

marked this merge request as ready

requested review from @paleo

CI fails today because of cuda - unrelated.

Tested on the blamed dataset. Works there.

closed

reopened

changed the description

added 1 commit

• fb4580dd - Add take_log parameter

Compare with previous version

Thanks, good catch.

CompositeCORFinder is the only estimator not inheriting from CORFinderBase (technically it does, but it still does the flatfield and normalization by itself instead of using the parent method). One day it would be good to rewrite this estimator in a cleaner way.

I also added take_log as a parameter

resolved all threads

mentioned in commit 23b49f12

merged

picked the changes into the branch cherry-pick-23b49f12 with commit 782dd4d9

mentioned in commit 782dd4d9