Pagopag
About
Pagopag means Paganin over Paganin. It applies in the volume (reconstructed) space a filter equal to the ratio of of two Paganin kernel at different delta/beta. And it applies according to a threshold which keeps out the low delta/beta regions
To do
-
Implement feature (class and docstring) -
Unit tests -
Integrate in pipeline -
End-to-end reconstruction test
Notes
Additional notes, ex. implementation details.
Edited by myron
Merge request reports
Activity
Filter activity
requested review from @paleo
assigned to @mirone
added 329 commits
-
593c0746...ca7eb50c - 328 commits from branch
master
- 52f09940 - hard-rebasing on master
-
593c0746...ca7eb50c - 328 commits from branch
added 10 commits
-
2d15946d...78622d1c - 9 commits from branch
master
- 247633cc - Merge branch 'master' into pagopag
-
2d15946d...78622d1c - 9 commits from branch
I still see many issues with this MR:
- new definition of
class PaganinPhaseRetrieval
. Perhaps better to do something likePaganinFilter3D
? It seems this is not a phase retrieval here. - Remaining debug traces, eg.
print(" url ", args.data_url)
- Use of
h5py.File
instead of fail-safe versions (eg.tomoscan.io.HDF5File
) - The
_make_plan
dispatch is exactly the purpose ofsilx.fft.fft
, avoiding 30 lines of code - Code duplication from
FullFieldReconstructor
:_get_memory
,_get_backend
, etc - The comments added to
gitlab-ci.yml
are not useful to the file and should instead be put in the MR chat
- new definition of
Please register or sign in to reply