Skip to content

Draft: Improve elmo whistle

Valentin Valls requested to merge improve_elmo_whistle into 1.11.x

Closes #3911

Few fixes from bm05 HRTOMO

This mostly make the axis state at DISABLED (instead of MOVING) when the servo is not yet enabled.

Finally it rewrite the display to make is similar to elmo.

HRTOMO [1]: yrot
   Out [1]: AXIS:
                 name (R): hryrot
                 unit (R): mm
                 offset (R): 240.00000
                 backlash (R): 0.00000
                 sign (R): -1
                 steps_per_unit (R): 2000.00
                 tolerance (R) (to check pos. before a move): 0.0001
                 motion_hooks (R):
                      <tomo.helpers.sample_stage_motion_hook.SampleStageMotionHook object at 0x7f37708f8a60>
                 limits (RW):    Low: 255.67925 High: -255.67925    (config Low: inf High: -inf)
                 dial (RW): 0.00000
                 position (RW): 240.00000
                 state (R): DISABLED (Axis cannot move) | CLOSEDLOOPOPEN (Closed loop open)
                 acceleration (RW):    8.00000  (config:    8.00000)
                 acctime (RW):         2.00000  (config:    2.00000)
                 velocity (RW):       16.00000  (config:   16.00000)
                 velocity_low_limit (RW):            inf  (config: inf)
                 velocity_high_limit (RW):            inf  (config: inf)
            ELMO WHISTLE CONTROLLER
                 version: Whistle 2.02.07.00 10May2006
                 comm:    SERIAL type=TANGO url=tango://d05/serialrp_0/30_10
                   timeout(s)=5.0 eol=b';'

            Status Register:
                 SR: 0x00006240
                 AMPLIFIER: OK
                 SERVO: disabled
                 Ext. Reference: disabled
                 Motor Failure: Ocurred
                 Homing: none
                 User Program: NOT running
                 Current Limit: limited to CL[1]
                 Safety Input 1: safety
                 Safety Input 2: none
                 RECORDER status: NOT active
                 Limit Switch: none

            Input Port Register:
                 IP: 0x00630200
                 Hard stop: Active
                 Digital input 1: Active
                 Digital input 2: Active
                 Digital input 6: Active
                 Digital input 7: Active

            ENCODER:
                 None

            CLOSED LOOP:
                 None

This was not yet tested because the beamline is not ready right now, but could be tested at ID19.

I flag it as "Draft" while it is not tested.

It have to be backported to 2.0 when it will be tested.

FYI @muzelle

Edited by Valentin Valls

Merge request reports