Skip to content

Draft: Create bliss.beacon package

Valentin Valls requested to merge beacon-package into master

Closes #2177

This MR moves modules to create a bliss.beacon package. The aim is to make the architecture a bit cleaner.

It's a rework from !3055 (closed) to restart stuffs from scratch.

Reworked layout

bliss/beacon/
├── client.py
├── connection.py
├── protocol.py
├── app/
│   ├── server.py
│   ├── server_list.py
│   └── log_server.py
└── webapp/
    ├── configuration/
    │   ├── main.py
    │   └── resources/
    └── homepage/
        ├── main.py
        └── resources/

Comment

  • There is probably clean up to do to split what is about BLISS and what is about Beacon (in bliss.beancon.client, bliss.beancon.connection), i can't tell
  • bliss.config.plugins.session contains an import from from bliss.beacon.webapp.configuration.main. Sounds weird.
  • Would be good to split beacon related tests too
  • It would be good to create a deprecated bliss.config.conductor.client, bliss.config.conductor.connection, bliss.config.conductor.protocol for few BLISS release (see !3055 (closed))
Edited by Valentin Valls

Merge request reports