Skip to content

Improved error message by fixing indentation of raised exception

Thomas Vincent requested to merge better-error-message into main

Issue reported on ID31, with scan without saved images:

Traceback (most recent call last):
  File "/opt/bliss/conda/miniconda/envs/ewoksworker/lib/python3.9/site-packages/ewokscore/task.py", line 401, in execute
    self.run()
  File "/opt/bliss/conda/miniconda/envs/ewoksworker/lib/python3.9/site-packages/ewoksxrpd/tasks/integrate.py", line 458, in run
    intensity_writer.flush_buffer()
AttributeError: 'NoneType' object has no attribute 'flush_buffer'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/bliss/conda/miniconda/envs/ewoksworker/lib/python3.9/site-packages/celery/app/trace.py", line 453, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/opt/bliss/conda/miniconda/envs/ewoksworker/lib/python3.9/site-packages/celery/app/trace.py", line 736, in __protected_call__
    return self.run(*args, **kwargs)
  File "/opt/bliss/conda/miniconda/envs/ewoksworker/lib/python3.9/site-packages/ewoksjob/apps/ewoks.py", line 26, in new_celery_task
    return celery_task(self, *args, **kwargs)
  File "/opt/bliss/conda/miniconda/envs/ewoksworker/lib/python3.9/site-packages/ewoksjob/apps/ewoks.py", line 45, in new_celery_task
    return celery_task(*args, **kwargs)
  File "/opt/bliss/conda/miniconda/envs/ewoksworker/lib/python3.9/site-packages/ewoksjob/apps/ewoks.py", line 61, in execute_graph
    return ewoks.execute_graph(*args, **kwargs)
  File "/opt/bliss/conda/miniconda/envs/ewoksworker/lib/python3.9/site-packages/ewoks/bindings.py", line 78, in execute_graph
    result = mod.execute_graph(graph, execinfo=execinfo, **execute_options)
  File "/opt/bliss/conda/miniconda/envs/ewoksworker/lib/python3.9/site-packages/ewokscore/events/contexts.py", line 25, in wrapper
    return method(*args, execinfo=execinfo, **kw)
  File "/opt/bliss/conda/miniconda/envs/ewoksworker/lib/python3.9/site-packages/ewokscore/bindings.py", line 56, in execute_graph
    return sequential.execute_graph(taskgraph.graph, **execute_options)
  File "/opt/bliss/conda/miniconda/envs/ewoksworker/lib/python3.9/site-packages/ewokscore/graph/execute/sequential.py", line 122, in execute_graph
    task.execute(
  File "/opt/bliss/conda/miniconda/envs/ewoksworker/lib/python3.9/site-packages/ewokscore/task.py", line 407, in execute
    raise RuntimeError(f"Task '{self.label}' failed") from e
RuntimeError: Task 'integrate' failed

Fixing the indentation will improve the error message

Merge request reports