Resolve "Remove the Dim enum" (!57) · Merge requests · workflow / ewoksapps / est

Wout De Nolf requested to merge 49-remove-the-dim-enum into main Jun 17, 2022

The Dim enum seems over-design which is missing the purpose of making sure the dimensions are a sequence of 0, 1 and 2.

If anything the dimensions could be a named tuple namedtuple('Point', 'x y channel') but I don't think its worth the serialization/deserialization. The tuple is only really used (not just passed) in transform_to_standard.

This MR also adds a test for transform_to_standard and a bug fix.

Also the standard dimensions (2, 1, 0) was specified everywhere as default. Now it's centralized.

Edited Jun 18, 2022 by Wout De Nolf

Resolve "Remove the Dim enum"

Merge request reports