Skip to content

Update major deps (except MUI)

Loic Huder requested to merge up-major-deps into main

Cypress to 13.3.0

Test isolation https://docs.cypress.io/guides/references/changelog#12-0-0

Some e2e tests (mostly links) were relying on the state left by the previous it block, while Cypress now clears up everything after each it block.

So I had to make a few changes so that tests now works when starting with a clean state. I think it is for the best since it decouples tests.

Aliases are now requeried rather than being static

This was breaking a few tests in nodes. For example, there is one where we change the label of the node and then check that the label inside @node indeed changed. Since changing the label changes the node/button label, quering the node again failed. I used {type: static} to keep the old behaviour (https://docs.cypress.io/guides/references/migration-guide#Behavior-Changes-in-Alias-Resolution)

Prettier to 3.0.3

Well, you know about this one and the new trailing comma default

axios to 1.5.3

Not much to see here. Most of the queries are now done with react-query anyway.

react-error-boundary to 4.0.11

The error field in FallbackProps now resolves to any rather than Error. This means additional type-checking is needed to use error.message in the fallback component.

Strangely, TS does not raise an error when error.message is used in JSX with error inferred to any 🤔. Perhaps we need to revisit this in h5web as well (https://github.com/silx-kit/h5web/blob/1a50827e19cb2b5507644db6e72265633a7e75d3/packages/app/src/ErrorFallback.tsx#L11).

Other updates I didn't do

Typescript to 5.x

pnpm start throws a webpack error so I couldn't update. I guess it is because create-react-app is not compatible with TS 5 ? I'll wait for the vite migration to retry this.

nanoid to 5.x

Version 5.x drops the support for Node 16.

react and MUI

These will be the focus of dedicated MR.

Edited by Loic Huder

Merge request reports

Loading