Skip to content
Snippets Groups Projects

Resolve "Output node conditions"

Merged Resolve "Output node conditions"
18-output-node-conditions into main
1 unresolved thread
Merged Wout De Nolf requested to merge 18-output-node-conditions into main
1 unresolved thread

Closes #18 (closed)

Input nodes and output nodes can have default link attributes which will be used whenever making links with a super-graph. The link attributes in the super graph have priority.

Edited by Wout De Nolf

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
doc/definitions.rst
87 83
88
89 In case the referenced nodes are graphs, the node inside that graph needs to be references with the `"sub_node"` key.
90 For example
84 For example for a graph with nodes `"id1"` (normal node) and `"id2"` (graph with an input node `"alias3"`):
91 85
92 86 .. code-block:: json
93 87
94 88 {
95 89 "graph": {
96 90 "input_nodes": [
97 {"id": "alias1", "node": "name1", "sub_node": "name3"},
98 {"id": "alias2", "node": "name2", "sub_node": "name4"},
91 {"id": "alias1", "node": "id1"},
92 {"id": "alias2", "node": "id2", "sub_node": "alias3"},
99 93 ]
  • payno
    payno @payno ·
    Owner

    Viewing the example make me a bit confused especially about id and node:

    • id values are aliasXX
    • node values are idXXX

    Sorry but reading it again make me wonder if we shouldn't call:

    • id -> super_graph_id: mandatory
    • node -> graph_id (or local_id or id): mandatory
    • sub_node -> sub_node_id : optional

    And maybe add a scheme with this graph and a super graph and a subgraph to make it 100% clear.

  • Wout De Nolf
    Wout De Nolf @denolf ·
    Author Owner

    We had a discussion on this: #13 (closed) Feel free to re-open the discussion.

  • Wout De Nolf
    Wout De Nolf @denolf ·
    Author Owner

    I modified the docs. Is it better?

  • Wout De Nolf
    Wout De Nolf @denolf ·
    Author Owner

    I propose we keep the API change for another MR.

  • payno
    payno @payno ·
    Owner

    fine with me. I don't have other comments on the PR

  • Please register or sign in to reply
  • Wout De Nolf added 1 commit

    added 1 commit

    • 690c7513 - doc: clarify input_nodes/output_nodes usage

    Compare with previous version

  • payno merged

    merged

  • payno mentioned in commit 7b424695

    mentioned in commit 7b424695

    • Please register or sign in to reply