Skip to content
Snippets Groups Projects

Replace `inputs_complete` by `force_start_node` to forcefully mark nodes as start nodes

Merged Loic Huder requested to merge start-node into main
3 unresolved threads

Fix #58 (closed)

Related to ewoksppf#16

Merge request reports

Merge request pipeline #195378 passed

Merge request pipeline passed for 4676d81f

Test coverage 82.75% (0.00%) from 4 jobs

Merged by Loic HuderLoic Huder 6 months ago (Sep 10, 2024 12:09pm UTC)

Loading

Pipeline #195408 passed

Pipeline passed for bc7faedb on main

Test coverage 82.75% (0.00%) from 4 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
151 151 {
152 152 "default_inputs": [{"name":"a", "value":1}]
153 153 }
154 * *inputs_complete* (optional): set to `True` when the default inputs cover all required inputs
155 (used for *method*, *script* and *notebook* as their required inputs are unknown)
154 * *start_node* (optional): when set to `True`, the node will be explicitly defined as a start node i.e. a node that should be executed before all others.
155 (To be used as an escape hatch when the graph analysis fails to correctly assert the start nodes).
  • Loic Huder changed title from Replace input_complete by start_node to explicitly mark nodes as start nodes to Replace input{+s+}_complete by start_node to explicitly mark nodes as start nodes

    changed title from Replace input_complete by start_node to explicitly mark nodes as start nodes to Replace input{+s+}_complete by start_node to explicitly mark nodes as start nodes

  • 1 import pytest
    2 import os.path
    3 from ewokscore import Task
    4 from ewoks import execute_graph
    5
    6
    7 def test_explicit_start_node_on_self_triggering_node(tmpdir):
  • Loic Huder added 1 commit

    added 1 commit

    • 5ca0ceaf - Replace `inputs_complete` by `start_node` to explicitly mark nodes as start nodes

    Compare with previous version

  • Loic Huder requested review from @denolf

    requested review from @denolf

  • Loic Huder mentioned in merge request !228 (closed)

    mentioned in merge request !228 (closed)

  • Loic Huder mentioned in merge request ewoksppf!101

    mentioned in merge request ewoksppf!101

  • 297 296 return False
    298 297
    299 298
    299 def node_is_start_node(graph: networkx.DiGraph, node_id: NodeIdType) -> bool:
    300 node = graph.nodes[node_id]
    301 if node.get("start_node", False):
    • Coming to think of this, none of the workflow engines other than ewoksppf use this. It's not going to be easy to support it in Orange for example ...

    • In this case, it is perhaps the execute_graph function of ewoksppf that should have a new parameter to specify start_nodes explicitely ?

    • Please register or sign in to reply
  • Wout De Nolf approved this merge request

    approved this merge request

  • Loic Huder added 1 commit

    added 1 commit

    • 4676d81f - Replace `inputs_complete` by `force_start_node` to forcefully mark nodes as start nodes

    Compare with previous version

  • Loic Huder changed title from Replace inputs_complete by start_node to explicitly mark nodes as start nodes to Replace inputs_complete by {+force_+}start_node to forcefully mark nodes as start nodes

    changed title from Replace inputs_complete by start_node to explicitly mark nodes as start nodes to Replace inputs_complete by {+force_+}start_node to forcefully mark nodes as start nodes

  • merged

  • Loic Huder mentioned in commit bc7faedb

    mentioned in commit bc7faedb

  • Loic Huder mentioned in issue ewoksppf#16

    mentioned in issue ewoksppf#16

  • Please register or sign in to reply
    Loading