Rework shutter state
I would like to rework the shutter state in order to make it consistent.
Related to daiquiri-ui#12
We have inherited shutter state from Tango, which is really not convinient.
- According to the kind of device a state could mean that the shutter is open or closed (for example a
SafetyShutter
inFAULT
is closed, which is maybe not the same case for others) - BLISS provides a
is_open/is_closed
API but it is not exposed as properly in Daiquiri - The
is_open/is_closed
is independent to the state, which is kind of weird when we want to display shutter is a widget. That's kind of duplicating
See the screenshot bellow. There is no symmetry between shutters and motors.
Proposal
- On Daiquiri server
- Use the
is_open
/is_closed
state from BLISS - Still share the state, optionally as a list, like motor state.
DISABLED
with be exposed as["CLOSED", "DISABLED"]
- Use the
- On Daiquiri UI
- OPEN/CLOSED will be displayed as a position for a motor
- The state for only
OPEN
orCLOSED
will beREADY
- As result the widget will easier to read, because symmetric with motor widget (and mostly any other widget)
Here is what we could have by default:
This shutter is open. The action have to be done on a drop down list, but that's something we can discuss (it was easier for the screenshot).
It's mostly what we have with a variant shutter, but it could be a bit more strong in some side cases.
Edited by Valentin Valls