Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • tomoscan tomoscan
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 14
    • Issues 14
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • tomotools
  • tomoscantomoscan
  • Merge requests
  • !22

Frm tomwer to tomoscan2

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged payno requested to merge frm_tomwer_to_tomoscan2 into master Aug 21, 2020
  • Overview 0
  • Commits 11
  • Pipelines 5
  • Changes 10

Question

Before merging commit containing get_sinogram and the flat_field_normalization we should ask ourself how much processing we want to integrate in tomoscan.

To get sinogram we need to embed the flat_field_normalization. And for the flat field normalization we need to compute / get mean / median dark and flats (normed_flats and normed_dark in the code).

So:

  • do we want this to be part of tomoscan ?
  • do we want to create a third library / class for this processing ?
  • do we let this to the applications ?

TODO

  • move some unit test from tomwer to tomoscan
  • add get_sinogram function to TomwerScanBase and implementation
  • add flat field normalization ??? for now the code included is used for 'simple visualization' and is making some approximation.
  • tests
  • name standardisation ?
Edited Sep 03, 2020 by payno
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: frm_tomwer_to_tomoscan2