Skip to content

Review 0

payno requested to merge payno/nxtomomill:review_0 into master

TODO:

  • add a .gitignore
  • add some PEP8
  • clean
  • add unit tests
  • add setup.py
  • add requirements.txt
  • add a script / an application to run tomoedf2h5
  • display progress
  • to be discuss:
    • replace the 'TomoScan' class by a dependence on TomoScan: should simplify the scripts and solve several issues like l 107: will fail if we have some .edf reconstruction or other file with the extension.
    • rename 2h5 by 2nx to avoid confusion (otherwise we might end up with a h52h5)

Missing:

  • what about units ? For example now pixel size is store as micrometer but nothing is specify. So:
    • should we use meter instead ?
    • how to specify the unit in the file
  • Information regarding ref and darks about integration time, method... or do we expect those to be 'ready to be processed' ?
Edited by payno

Merge request reports