Skip to content
Snippets Groups Projects

Refactor MX image viewer

Merged Axel Bocciarelli requested to merge refact-mximage into main
All threads resolved!
  • Split the h5grove provider into a separate component and use composition to avoid forwarding props to the underlying visualisation.
  • Rename the components, notably using the MX prefix for the underlying visualization, since it's really specific to the MX use case for now.
  • Pass the resolve_links=all query param to h5grove so it responds with an error if it can't resolve an HDF5 link entity (soft or external).
  • Remove some unnecessary tsconfig.node.json files in the packages (they're for linting vite.config.js files, but the shared packages don't have any).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marjolaine Bodin approved this merge request

    approved this merge request

  • Marjolaine Bodin requested review from @bodin

    requested review from @bodin

  • added 1 commit

    • ac49330b - Rename `MXImageVis` to `ImageVisForMXData`

    Compare with previous version

  • Axel Bocciarelli resolved all threads

    resolved all threads

  • Axel Bocciarelli enabled an automatic merge when all merge checks for ac49330b pass

    enabled an automatic merge when all merge checks for ac49330b pass

  • mentioned in commit 09449be7

  • Please register or sign in to reply
    Loading