Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Datahub Datahub
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 63
    • Issues 63
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ICAT
  • DatahubDatahub
  • Merge requests
  • !431

Move ICAT+ server URL to environment variable

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Axel Bocciarelli requested to merge env into master Aug 31, 2020
  • Overview 11
  • Commits 2
  • Pipelines 3
  • Changes 8

The first step to move some of the most environment-specific configuration options to environment variables.


Like in ICAT+, moving to environment variables for some options (not all) has many advantages:

  • Each environment can have its own configuration (until now, icatPlus.example.js was the production configuration).
  • Default values for every environment (dev/test/prod) appear directly in the version-controlled source code, which is good for discoverability and for developer induction (i.e. new devs have a set-up that works out of the box).
  • Default environment values can easily be overridden in .env.*local files without impacting other developers, since these files are not overriden.
  • A developer's configuration doesn't get overridden when running npm run build, so it is now easier to build the app with development variables for testing purposes.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: env