Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
Datahub
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ICAT
  • Datahub
  • Merge Requests
  • !431

Merged
Opened Aug 31, 2020 by Axel Bocciarelli@bocciare
  • Report abuse
Report abuse

Move ICAT+ server URL to environment variable

  • Overview 11
  • Commits 2
  • Pipelines 3
  • Changes 8

The first step to move some of the most environment-specific configuration options to environment variables.


Like in ICAT+, moving to environment variables for some options (not all) has many advantages:

  • Each environment can have its own configuration (until now, icatPlus.example.js was the production configuration).
  • Default values for every environment (dev/test/prod) appear directly in the version-controlled source code, which is good for discoverability and for developer induction (i.e. new devs have a set-up that works out of the box).
  • Default environment values can easily be overridden in .env.*local files without impacting other developers, since these files are not overriden.
  • A developer's configuration doesn't get overridden when running npm run build, so it is now easier to build the app with development variables for testing purposes.
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: icat/E-DataPortal!431

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.