Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D Datahub
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 51
    • Issues 51
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ICAT
  • Datahub
  • Merge requests
  • !413

Merged
Created Aug 24, 2020 by Axel Bocciarelli@bocciareMaintainer

Clean up index.html and move external CSS imports to index.js

  • Overview 10
  • Commits 2
  • Pipelines 4
  • Changes 17

All the external CSS imports now go in index.js for clarity.

For react-combo-search and its two peer deps (react-combo-select and react-datetime), the imports no longer point to local stylesheets but to the stylesheets available in node_modules. I've also re-added the two peer deps to package.json for ESLint and used a version number for react-combo-search instead of a git URL.

Since there were inconsistencies between the local styles and the node_modules styles, I went ahead and wrote my own overrides from scratch. The combo search component is used on the logbook. I've actually fixed a bug where the After radio button could not be selected.

BEFORE

image

AFTER

image

Edited Aug 24, 2020 by Axel Bocciarelli
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: index