I was thinking about the iFrame to display the viewer however looking at the resolution most used for laptops I am afraid that it might be be too small
Edited
Designs
Child items
...
Show closed items
Linked items
0
Link issues together to show that they're related.
Learn more.
The iframe is just a technical detail. My question was related to the second statement, where would you free the space for the viewer? horizontally aligned with the row of the file? Below the table?
In fact I like the idea but we would need to optimise the h5web display. Maybe we can reduce the use of white space by collapsing the menu + controls? Does this option provide the possibility of stepping through files on the same web page?
Yes, my feeling is also that even if we can embed the viewer inside the data portal somewhere, it has been designed to be as an standalone application and not a widget which makes the user interface "unusual".
Nevertheless, it is better than the current one.
I propose to use the bootstrap layout then the viewer will be displayed horizontally if the screen is large otherwise it will be shown below the table.
I'll deploy so you can try
The h5web service is down apparently. I get an empty frame and when I click on open view the url times out. Can you fix this?
Small comment on the UI - I think the view button should be on the left with the download and have a popup. Or to go back to the link for h5 files with a popup saying what will happen.
Looks great i.e. I like it! I had two more suggestions to make:
(1) before a file is previewed the space where the iframe will be open is empty. It would look better if it was filled with a text like "To preview data in a file please select the preview icon next to the file."
(2) add a button on the viewer to open viewer in jupyterlab.
I don't know how difficult/easy (2) is but I am sure @loic.huder can help.
You are totally right. I always get confuse when the tab files shows my home and it does not allow to go to /data (or I don't know how) but it is perfectly accessible from a terminal.
Sorry for the mistake.
In this particular case, I did the MR a couple of weeks ago but I did not deployed until few minutes ago when we got a bunch of MR to deploy...
I take note for disabling the cache.