Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
D
Datahub
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 93
    • Issues 93
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ICAT
  • Datahub
  • Issues
  • #460

Closed
Open
Opened Oct 20, 2020 by Maxime Chaillet@mchaille
  • Report abuse
  • New issue
Report abuse New issue

Change the user message 'Logbook is empty'

This message is not appropriate because it is displayed:

  • when the logbook is empty, no events are in the logbook at all
  • when the filters are set such that no event is found.

In the second case, the message 'Logbook is empty' is wrong and will confuse people.

In order to distinguish between point 1 and point 2 (and display a different message for each), one could make an additional request to icat+ to get the count of all events in the logbook. This solution seems overkill to me at the moment.

The easiest solution is to change the message to:

'No log found'

Edited Oct 20, 2020 by Maxime Chaillet
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
1
Labels
logbook
Assign labels
  • View project labels
Reference: icat/E-DataPortal#460