Skip to content
Snippets Groups Projects

Resolve "Icat: composition instead of inheritance"

Open Resolve "Icat: composition instead of inheritance"
4689-icat-composition-instead-of-inheritance into master
Open Wout De Nolf requested to merge 4689-icat-composition-instead-of-inheritance into master

Closes #4689

Tested in production at ID00.

  • Move the IcatClientInterface and IcatNullClient classes back to bliss (it was a bad idea)
  • Remove imports that are deprecated (0.7.0): icat/pyicat-plus!137 (merged)

This works with the current and previous pyicat-plus versions. The next version will drop deprecated API (like IcatClientInterface and IcatNullClient). This MR is also removing deprecated API usage.

Edited by Wout De Nolf

Merge request reports

Merge request pipeline #231166 passed

Stage: style
Stage: build
Stage: package
Stage: tests
Stage: doc

Merge request pipeline passed for 8f1a2348

Approval is optional
Ready to merge by members who can write to the target branch.

Merge details

  • The source branch is 37 commits behind the target branch.
  • 5 commits and 1 merge commit will be added to .
  • Source branch will not be deleted.

  • Closes issue #4689

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply