Skip to content

Resolve "Improve feedback when problems with ICAT"

Closes #3568 (closed)

Before this MR

When there are unconfirmed ICAT datasets when calling newproposal or endproposal, the user is prompted with this question

┌──────────────| The current proposal has 1 datasets that are not registered with ICAT |──────────────┐
│                                                                                                     │
│ Are you sure you want to change proposal?                                                           │
│ You could answer 'No' and retry in few seconds.                                                     │
│ Please check the data portal before answering 'Yes'.                                                │
│                                                                                                     │
│                                      <   Yes    > <    No    >                                      │
│                                                                                                     │
└─────────────────────────────────────────────────────────────────────────────────────────────────────┘

Feedback from several beamlines (@wright, @cdejoie): we don't understand the question and we don't want prompts (in case of usage in macro's).

After this MR

When there are unconfirmed ICAT datasets when calling newproposal or endproposal, the following message is printed (on the shell and in the e-logbook)

Unconfirmed datasets are stored in /data/id00/inhouse/id002211/id00/20221101/__icat__

You may need to send them to ICAT manually with the command

  icat-store-from-file /data/id00/inhouse/id002211/id00/20221101/__icat__/*.xml

The directory <base_path>/<proposal>/<beamline>/<session>/__icat__ is a choice I made (might change in the future, maybe _nobackup/icat?).

Edited by Wout De Nolf

Merge request reports