Skip to content

Draft: Rework calccontroller + xyonrotation

Valentin Valls requested to merge create-real-param into master

see issue #3036 (closed)

This PR includes few things i wanted to change in the xyonrotation to make it a bit more easy to use.

  • Added real_param for an input axis which have to be used as input for both calc_to_real and real_to_calc. Also, this axis must never be part of the output of this functions
  • No need to specify any more real or real_param in the yaml file (the implemented controller already knows such thing because you already have to specify rot/x/y/rx/ry in your yaml file, see _set_tag_per_role)
  • Allow to move together a real_param and a pseudo

This changes was implemented including non regression test for the yaml configuration file as it was for BLISS 1.10.

Model

The modelization of such controller can be seen this way

calccontroller

  • If you move real axes, the calc axes will be updated
  • If you move calc axes, the real axes will be updated
  • If you move the real_param, the calc axes will be updated
  • You can move both real and real_param at the same time
  • You can move both calc and real_param at the same time
Edited by Perceval Guillou

Merge request reports