Skip to content

Resolve "timeout arg from an RPC call is used to setup client side RPC timeout"

Valentin Valls requested to merge 2557-timeout-arg-from-an-rpc-call-is-used-to-setup-client-side-rpc-timeout into master

Closes #2557 (closed)

This MR remove timeout use in RPC calls.

Here is the rational:

  • This argument is passed to RPC call, so it have to be defined by the remote call argument, and then it is used for something in server side (while it also setup the client side)
  • So this argument is catch in an hidden way, which is dangerous
  • The functionality can be achieved by the caller with gevent.Timeout
  • Finally it looks to be unused

Better to remove it than to fall down one of this day.

Edited by Valentin Valls

Merge request reports