Skip to content

Adapt PI controllers to use consistent communication configuration

Jose Tiago Macara Coutinho requested to merge consistent_comm_pi into consistent_comm

Hi @cyril.guilloud,

I implement the #73 (closed) for the PI controllers:

  • add support for new communication configuration
  • add deprecation warning if using original configuration

Notes:

  • I remove the feature __sock_map since it has a memory leak. Do you have the case of two controller names which refer to the same PI? We can add this together if you really need it but it should be a weakref.WeakValueDictionary. Better even would be to ask @sebastien.petitdemange for a proxy connection feature.
  • I tested with PI-712
  • I added deprecation warnings. You need to start python with python -Wd if you want to see the deprecation messages in your console. This will help migrating

Merge request reports