Skip to content

Beamline attributes, movables and actuators

Created by: marcus-oscarsson

Hello !

This is various fixes related to the actuators and movables. They were all working a while back a go when tested on a beamline, various refactoring and updates have then broken the functionality slightly. I could basically not use the controls to control the "movables" (energy, resolution ...). For those I could set the intermediate values (no value changes) were not handled.

So I have merged actuators and movables into one concept called attributes (as in beamline attributes), the name is maybe poorly chosen. It can definitely be changed if someone have a better suggestion. The reason for doing this was simply that the actuators and movables where all handled the same by the backend logic so there is no need to add extra logic to separate them in the UI or in the backend for that matter.

Ive added the machine info in the same way (as an attribute), and added the necessary logic to handle it. The cryo attribute used a custom made CryoInput which I changed to a PopInput, I dont know what the original intent with that was but it did not seem to provide more functionality, please correct me if Im wrong.

So I finally got all the beamline attributes to work here (on ID29 and mockup ...), set, get and change events. It seems that we need to work a little bit more on abort, it is not as immediate as one would like (at least in my opinion). A small detail that we need to look at is how to couple the resolution and detector distance in a convenient way.

Thanks, Marcus

Merge request reports