Skip to content

Shapes (Mesh Scan Part 1)

Marcus Oskarsson requested to merge gh-a0bc477e/504/marcus-oscarsson/grid-collection into master

Created by: marcus-oscarsson

Hi,

Another big PR, sorry for that, (Please note that this PR is Dependent on PR #220 of HO)

Working on the mesh scans I noticed that the centered positions was not stored in a way that was compatible with how some parts of MXCuBE works.

The Points was simply attached to a dictionary on the diffractometer, this will of course works fine for just storing the positions. However, it wont work in general, since other parts of MXCuBE needs to access that data. An API for accessing Shapes is already specified by the HO called ShapeHistory. This HO is dependent on Qt so it wont work for us, so I've created a new HO called Shapes that is completely independent of UI library.

So this PR:

  • Adds Shapes HO which manages Shapes (Points, Lines and Grids) in a way which is compatible with MXCuBE

  • Generalizes the REST-API for Points (previously called centrings in the REST-API) to handle Shapes in general

  • Refactors reducers and components to handle shapes instead of points.

All this is necessary to get the Mesh scans and workflows to work properly, so I will rename this Shapes (Mesh Scan Part 1), part 2 will put the final bits in place.

Marcus

Merge request reports