Skip to content

[Do not merge ! Contains things to discuss] Fixes (#393, #394, #387) and questions

Created by: mguijarr

Hi all,

While working on the snapshots feature on ID30A3, I stumbled into issues I try to fix in this PR. Maybe some things are not bugs but features, although I find some things very confusing.

So please look at my changes and commits and let's review all this :)

The more important questions I have are related to Manual Mount mode: how is the Manual Mount mode supposed to work ? How is it supposed to work with the Grid ? What a user is expected to do ? My biggest concern is that I found Manual Mount being something in-between a manual (human) sample changer implementation within the queue, and the 'free-pin' mode in MXCuBE 2. Then, I started to have a deeper look at dffractometer.use_sc ; my goal is to remove this since it is unclear what it is supposed to do. Finally I looked at the sample grid, I realized it was being updated far too much times and I fixed it, at least temporarily (see last commit).

Merge request reports

Loading