Skip to content
Snippets Groups Projects

do not start centring if no sample is mounted

Merged Marcus Oskarsson requested to merge gh-211fd40a/419/meguiraun/manual_mount_fixes into master

Created by: meguiraun

just display the error message modal and do not launch the centring.

Merge request reports

Merged by avatar (Jan 10, 2025 9:45pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
146 method: 'PUT',
147 credentials: 'include',
148 headers: {
149 Accept: 'application/json',
150 'Content-type': 'application/json'
151 }
152 }).then((response) => {
153 if (response.status >= 400) {
154 throw new Error('Server refused to start 3click');
155 } else {
156 dispatch(startClickCentring());
157 }
158 });
159 };
144 return function (dispatch, getState) {
145 const { queue } = getState();
  • Created by: marcus-oscarsson

    Hi again,

    In which context is this method used, I can imagine that its useful to be able to center even if there is no sample mounted. It should perhaps not be possible to collect but to center.

    They scientists sometimes put special pins on the goniometer, these pins can for instance be used to find the beam or do other diagnostics. So they would probably like to center these pins, but I might be wrong.

    I think what Matias asks in #389 (closed) is if its really necessary to always add a sample to be able to collect. Its today , in MxCuBE2, possible to center and collect without really having the concept of a sample. We could theoretically enter the hutch and put an apple to the gonio, center and collect. Without passing through ISPyB or adding acronym or sample name.

    Its a question for our respective scientists ...

    Marcus

  • 146 method: 'PUT',
    147 credentials: 'include',
    148 headers: {
    149 Accept: 'application/json',
    150 'Content-type': 'application/json'
    151 }
    152 }).then((response) => {
    153 if (response.status >= 400) {
    154 throw new Error('Server refused to start 3click');
    155 } else {
    156 dispatch(startClickCentring());
    157 }
    158 });
    159 };
    144 return function (dispatch, getState) {
    145 const { queue } = getState();
  • 146 method: 'PUT',
    147 credentials: 'include',
    148 headers: {
    149 Accept: 'application/json',
    150 'Content-type': 'application/json'
    151 }
    152 }).then((response) => {
    153 if (response.status >= 400) {
    154 throw new Error('Server refused to start 3click');
    155 } else {
    156 dispatch(startClickCentring());
    157 }
    158 });
    159 };
    144 return function (dispatch, getState) {
    145 const { queue } = getState();
  • Created by: meguiraun

    At this moment you are able to center, and when you try to add a task you realize it is not possible since you have not mounted a sample. For me this is spending too much time for ending in nothing (you then need to add a sample and then repeat everything).

    I think we need the concept of sample, as a named and identifiable element. If a scientist puts a special pin they will be also able to easily find the associated data if we consider it as a sample (or whatever).

    In any case, the aim of this pr is not to solve if we need a sample or not, we are facing this annoying problem everyday and this is a way to decreasing the annoyance level.

  • 146 method: 'PUT',
    147 credentials: 'include',
    148 headers: {
    149 Accept: 'application/json',
    150 'Content-type': 'application/json'
    151 }
    152 }).then((response) => {
    153 if (response.status >= 400) {
    154 throw new Error('Server refused to start 3click');
    155 } else {
    156 dispatch(startClickCentring());
    157 }
    158 });
    159 };
    144 return function (dispatch, getState) {
    145 const { queue } = getState();
  • Created by: mguijarr

    We need to talk about this concept of sample in 'Manual mount' when there is no sample changer. I let this to the scientists. What we are missing is the 'free-pin' mode, which let people collect data quickly without having to create a 'sample'. For me Manual mount was free pin, in fact, but it's a different beast for you guys so we need an agreement from the product owners.

    For the moment the code seems fine in this PR so it gets merged :)

  • Created by: meguiraun

    thanks, I think is good to let the product owners fight on this ;)

  • Please register or sign in to reply
    Loading