Skip to content

Samplegrid

Created by: marcus-oscarsson

Hello all,

I wanted to make a PR out of this before it gets to big. What I did was simply to clean up the "interface" exposed by the action/SampleGrid.js. I also took a look at the action names and tried to give them a more well defined meaning, as far as that is possible, so it will be easier to debug.

I would like to take a deeper look at the logic in the reducer and maybe clarify/simplify the logic a bit. Ive noticed that the logic in the reducers quickly becomes quite messy and large (maybe its just me ?), I would like to do something about this at least for the SampleGrid reducer, what I have in mind is simply to extract certain things to functions and then adding some documentation. Perhaps someone have a better idea ?

I think it also would be really valuable to document the data model, store, so that its clear what it should contain and what each property does. Maybe this is good in general for reducers ?

Marcus

Merge request reports