Skip to content

Corrected small typo in TaskContainer

Created by: marcus-oscarsson

Hello,

I guess this one is for Fredirk or Anotnio, it seems like the last PR contained a typo (or am I mistaken). The file called samplesGrid does not exist (as long as you did not rename it and maybe forgot to commit that). It should be SamplesGrid :).

Its a bit weird because this typo would normally prevent the application from running, and I guess its running at your side so I'm asking myself if there is a commit missing somewhere ?

I agree that the name SamplesGrid is not the best name and it should perhaps be either samplegrid in lower case so that we are consistent with the other reducers and actions. Or SampleGrid (without the s) so that we are consistent with the other UI files, however that would force us to change name of all other actions and reducers. So I think that maybe samplegrid would be the best alternative so that we are consistent within the actions and reducers folders. What do you think ?, I can take the responsibility of changing the name since Im doing some sample grid related refactoring in anyways.

Anyhow, this fixes the problem.

Thanks, Marcus

Merge request reports

Loading