Skip to content

eslint --fix

Marcus Oskarsson requested to merge gh-2834bccb/184/mxcube/eslint into master

Created by: marcus-oscarsson

Hello everybody

I hope you had a nice trip back to Sweden, It was wonderful to see you all !.

So I started to perform the eslint fix, I have already managed to get rid of alot of errors but there is still plenty remaining. I have tested what Ive done here and it seem to work like before. Ill stop here for the moment to give you the possibility to try it out before I continue.

The --fix option is a little bit unstable and stops the fixing sometimes but continues the error report, so it looks like it did what it could to fix the errors. I don't know exactly why but it could be that some exception is raised and the error fixing is somehow aborted but the reporting is still done. Regardless of the cause, the result is as that it really looks like eslint fixed all the errors it could fix.

Sometimes just running it twice solves some more issues, fixing some manual and then running again sometimes also works. Running eslint on individual files ore sub directories work much better than the entire directory structure.

We still have some (not so few actually :) ) errors to fix but we also got rid of plenty. You can perhaps give the eslint --fix a try on the files that you are working on and see if it does any difference.

Thanks, Marcus

Merge request reports