Skip to content

Fixes after testing mxcubeqt with python3/qt5

Marcus Oskarsson requested to merge fixes_after_testing into master

Created by: IvarsKarpics

Here are some changes, fixes after testing the latest version of mxcubecore with python3/qt5 on the beamline p13

  • Beamline.py:
  1. added boolean run_offline_processing to indicate if by default the offline autoprocessing will be launched.
  2. added list variable offline_processing_methods and online_processing_methods to indicate autoprocessing pipelines (EDNAProc, Dials, etc). These names are displayed in the processing widget.
  3. added beamstop property. Several methods require beamstop parameters and it is convenient to access it via beamline object (and not via diffractometer hwobj)
  • DozorOnlineProcessing.py: fixed method name
  • ExporterMotor: renamed self.motor_position to self.chan_motor_position and self.motor_state to self.chan_motor_state. I would encourige people to use prefix chan_ and cmd_ to indicate if variable is channel or method. Otherwise it looks like variable describing position and state.
  • ExporterNState: changed value validation. To be discussed.
  • GenericDiffractometer: added force_emit_signals method
  • QtGraphicsLib: fixed bug if qt5 is used
  • VimbaVideo.py: rewrote hwobj to be compatible with the latest pymba library
  • AbstractBeam: init beam size defined by the beam definer
  • AbstractCollect, AbstractDetector: cleaned up the binning_mode (stored in ispyb)
  • AbstractEnergy: added get_undulators_gap method
  • AbstractShutter: added is_open, is_closed, open, close methods
  • queue_model_objects: get container (puck) code and add it to the display name

I will create a corresponding PR in mxcubeqt after merging this PR.

Merge request reports