Skip to content

Improved generic tests v3

Marcus Oskarsson requested to merge github/fork/rhfogh/ImprovedGenericTests_v3 into master

Created by: rhfogh

11 minutes ago

Replaces #529

For some reason the previous PR showed more differences than it should, so I am replacing it with a new cleaner version

@IvarsKarpics I have moved the abstract test classes to test/pytest (I made some silly errors with relative imports, which is why I could not get them to work there until IK showed me how).

@marcus-oscarsson I have added tests for emission of stateChanged, valueChanged, and limitsChanged.

@beteva
I removed the velocity-setting from AbstractMotor. But removing the changes in AbstractActuator caused the tests to fail. Maybe we need to change the tests too, or to change AbstractActuator so they pass in another way. but I think it is better that I make the PR so that the test pass, and leave it to you to make the modifications - after all you are the one who knows what we need here.

I only have use of this hotspot at short, irregular intervals; sorry for being mostly offline, still.

Merge request reports