Skip to content

WIP Proposal for new abstract Transmission class

Marcus Oskarsson requested to merge github/fork/rhfogh/abstract_attenuators_rhfogh_3 into master

Created by: rhfogh

Alternative proposal for AbstractTransmission (was AbstractAttenuators), for discussion. Contains an abstract class, a mock, and a sample implementation.

Some comments:

  • Transmission is a better name, since it is singular (unliker 'Attenuators') and since the associated value is a transmission. How it is implemented underneath is a matter for lower layers.

  • We should not have both public functions and properties, that clutters. And since we need some parameters, like 'timeout', functions it is.

  • It is better to have only one parameter, 'timeout', as proposed by Ivars, and avoid the 'wait' parameter. The syntax here has no way to say 'wait forever', if you want that you must give a long timeout, e.g. 999999s

  • I think it is better to have the parameters of getters and setters named uniformly 'value'. The signals and internal attributes have more descriptive names. Also my names are a bit shorter than Ivars'

  • Any implementation casn be made by implementing the six abstract methods in the AbstractTransmission. As much work as possible has been put in the acutal abstract class.

  • The implementation must take care of sending all signals, I can see no way of doing that from the top layer reliably. All state should be kept in the subclasses.

I shall shortly add another file, with an implementation matching Ivars Attenuators class

Merge request reports