Skip to content

Draft: ewoksify 'binning' orange widget

payno requested to merge refactor_binning_task into main

description

Fully move binning to ewoks widget. It requires an option to cancel / abort a job. So the following PR needs to be merged first:

TODO

  • do refactoring
  • ~ handle task cancellation~ some code is here but the 'abort' button is never displayed...
  • add some test

note on handling the 'update' parameter.

It was not 'straightforward' to understand the usage of the 'update' parameter contained in the OWSendSignal structure.

  • when the widget receive the signal update will be None, the dataset will be used for the display
  • Then the 'apply' button is doing some processing within the darfix.gui.binningWidget.BinningWidget. The Orange widget setDataset is not called
  • when 'ok' is called then setDataset is not called either.
  • once the processing is validated a sigComputed is connected to '_sendSignal' which will propagate the processing

most likely this variable is used if some widgets are connected together. Some OW can call upstream widgets to force some reprocessing. And then the propagation will be stopped when the widget which as created the update of upstream widgets is met.

But I couldn't find any related use-cases.

Edited by payno

Merge request reports