tomoscan merge requestshttps://gitlab.esrf.fr/tomotools/tomoscan/-/merge_requests2021-10-22T14:31:47+02:00https://gitlab.esrf.fr/tomotools/tomoscan/-/merge_requests/59add get_relative_file2021-10-22T14:31:47+02:00paynoadd get_relative_filefix #37fix #370.7https://gitlab.esrf.fr/tomotools/tomoscan/-/merge_requests/55Add validator2021-08-30T13:29:36+02:00paynoAdd validator# scope
Lately tomwer included a widget with some 'entry validation'. This could be extended to nabu for an application to check data prior to reconstruct them.
This could also be integrated in nxtomomill once the Nexus file is write d...# scope
Lately tomwer included a widget with some 'entry validation'. This could be extended to nabu for an application to check data prior to reconstruct them.
This could also be integrated in nxtomomill once the Nexus file is write down.
Tomwer would probably require those at the Entry level (so extra information could be provided in tooltip)
Nabu would probably need an interface like:
``` bash
nabu validator [file.h5/folder] [[entries]] [--no-phase-retrieval] [[--check-datasets]] [[--all-entries]]
```
# TODO
validators requested:
- [x] energy
- [x] distance
- [x] pixel size
- [x] darks (urls exists, check broken vds and nan)
- [x] flats (urls exists, check broken vds and nan)
- [x] projections (urls exists, check broken vds and nan)
- [x] High level validator for reconstruction (with or without phase retrieval)
- [x] improve readability
- at least adjust text on the left
- maybe we could add some icons on the terminal like 'black' for example for readability and fanciness ;)
- [x] improve vds check: look on virtual source to only check the dataset we are interested on.
# extra info
I expect the high level validator (for a reconstruction for example) to provide two 'analysis':
- summary:
```
- entryXXX@master_file.nx
- energy: valid
- darks: invalid: expected data in XXX
- projections: invalid: has broken virtualdataset link
- flats: invalid: contains nan...
- distance: valid
```
- resume:
```
- 3 issues:
- darks: invalid: expected data in XXX
- projections: invalid: has broken virtualdataset link
- flats: invalid: contains nan...
```
# API
a `single entry` validator or a `Reconstruction` validator should have the same API:
``` python
class ValidatorBase:
def is_valid(self):
...
def run(self):
...
def clear(self):
...
```
# extra info
close #35
should trigger https://gitlab.esrf.fr/tomotools/nabu/-/merge_requests/141
An example of result from nabu with source scan removed for dark and flat
![image](/uploads/6354ce32d9e896f4127d752ad8576a95/image.png)0.6paynopaynohttps://gitlab.esrf.fr/tomotools/tomoscan/-/merge_requests/36Speed up hdf5 sinogram load2021-03-29T16:44:01+02:00paynoSpeed up hdf5 sinogram load0.5https://gitlab.esrf.fr/tomotools/tomoscan/-/merge_requests/18add management of field of view2020-08-21T10:28:00+02:00paynoadd management of field of view0.3