Dependencies handling in setup.py
I have the following error in the CI of Nabu:
158 ___________ ERROR collecting preproc/tests/test_double_flat_field.py ___________
159 ImportError while importing test module '/root/.venv/py3/lib/python3.5/site-packages/nabu/preproc/tests/test_double_flat_field.py'.
160 Hint: make sure your test modules/packages have valid Python names.
161 Traceback:
162 /root/.venv/py3/lib/python3.5/site-packages/nabu/preproc/tests/test_double_flat_field.py:9: in <module>
163 from nabu.resources.dataset_analyzer import analyze_dataset
164 /root/.venv/py3/lib/python3.5/site-packages/nabu/resources/dataset_analyzer.py:3: in <module>
165 from tomoscan.esrf.edfscan import EDFTomoScan
166 /root/.venv/py3/lib/python3.5/site-packages/tomoscan/esrf/edfscan.py:37: in <module>
167 from lxml import etree
168 E ImportError: No module named 'lxml'
I believe I should first do a pip install -r requirements.txt
in the CI file.
However it would be good that the dependencies are automatically installed when we do a pip install tomoscan
(or pip install git+https://gitlab.esrf.fr/tomotools/tomoscan
for now).
To do so, the install_requires
has to be filled in the setuptools.setup
method. I don't know for distutils
.
What do you think ?