Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • EBS-Tomo EBS-Tomo
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 24
    • Issues 24
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • tomo
  • EBS-TomoEBS-Tomo
  • Merge requests
  • !93

Improve and add unittest for [d]zoom optics

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Valentin Valls requested to merge improve-dzoom into master Jul 06, 2022
  • Overview 0
  • Commits 7
  • Pipelines 3
  • Changes 14

This PR

  • Move the logic related to this optic into specific methods
  • Implement the inherited move_magnification
  • Update exposed target magnification
  • Update the final magnification (after a move) from motor locations
  • Added unittest (using config from BM18)

The tests show that there is a huge discrepancy between requested magnification, and resulting magnification (requested mag -> move motor -> motor pos -> computed mag). I can't tell if it is normal or not.

Edited Jul 06, 2022 by Valentin Valls
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: improve-dzoom