Commit 3adfdb97 authored by Sebastien Petitdemange's avatar Sebastien Petitdemange
Browse files

counters: simplify the adding of Sampling and Integrating counters in chain.

Now a part of internal is mask into helpers.
parent a4635eb6
......@@ -11,9 +11,23 @@ import gevent
from gevent import event
from bliss.common.event import dispatcher
from ..chain import AcquisitionDevice, AcquisitionChannel
from bliss.common.measurement import GroupedReadMixin
from bliss.common.measurement import GroupedReadMixin, Counter
from bliss.common.utils import all_equal
def _get_group_reader(counters_or_groupreadhandler):
list_iter = iter(counters_or_groupreadhandler)
except TypeError:
return counters_or_groupreadhandler, list()
first_counter =
reader = Counter.GROUPED_READ_HANDLERS.get(first_counter)
for cnt in list_iter:
cnt_reader = Counter.GROUPED_READ_HANDLERS.get(cnt)
if cnt_reader != reader:
raise RuntimeError("Counters %s doesn't belong to the same group" %\
return reader, counters_or_groupreadhandler
class BaseCounterAcquisitionDevice(AcquisitionDevice):
def __init__(self, counter, count_time, **keys):
......@@ -59,10 +73,13 @@ class BaseCounterAcquisitionDevice(AcquisitionDevice):
class SamplingCounterAcquisitionDevice(BaseCounterAcquisitionDevice):
def __init__(self, counter, count_time=None, mode=SIMPLE_AVERAGE, **keys):
def __init__(self, counters_or_groupreadhandler,
count_time=None, mode=SIMPLE_AVERAGE, **keys):
Helper to manage acquisition of a sampling counter.
counters_or_groupreadhandler -- can be a list,tuple of SamplingCounter or
a group_read_handler
count_time -- the master integration time.
mode -- three mode are available *SIMPLE_AVERAGE* (the default)
which sum all the sampling values and divide by the number of read value.
......@@ -74,8 +91,9 @@ class SamplingCounterAcquisitionDevice(BaseCounterAcquisitionDevice):
* prepare_once --
* start_once --
reader, counters = _get_group_reader(counters_or_groupreadhandler)
self, counter, count_time, **keys)
self, reader, count_time, **keys)
self._event = event.Event()
self._stop_flag = False
......@@ -83,6 +101,9 @@ class SamplingCounterAcquisitionDevice(BaseCounterAcquisitionDevice):
self._ready_flag = True
self.__mode = mode
for cnt in counters:
def mode(self):
return self.__mode
......@@ -173,9 +194,12 @@ class SamplingCounterAcquisitionDevice(BaseCounterAcquisitionDevice):
class IntegratingCounterAcquisitionDevice(BaseCounterAcquisitionDevice):
def __init__(self, counter, count_time=None, **keys):
def __init__(self, counters_or_groupreadhandler, count_time=None, **keys):
reader, counters = _get_group_reader(counters_or_groupreadhandler)
self, counter, count_time, **keys)
self, reader, count_time, **keys)
for cnt in counters:
def prepare(self):
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment