From 6f965649b2fb6f486b1c62698cfcdb8d860321ca Mon Sep 17 00:00:00 2001 From: Alejandro Homs Puron <ahoms@esrf.fr> Date: Wed, 13 May 2020 15:30:28 +0200 Subject: [PATCH] Add missing virtual destructor for Timer::Callback (abstract) class --- common/include/lima/Timer.h | 2 ++ common/sip/Timer.sip | 2 ++ 2 files changed, 4 insertions(+) diff --git a/common/include/lima/Timer.h b/common/include/lima/Timer.h index 725dbfb15..1eca8f903 100644 --- a/common/include/lima/Timer.h +++ b/common/include/lima/Timer.h @@ -38,6 +38,8 @@ namespace lima enum Stat {DOWN,DELAY,UP,RISING_EDGE,FALLING_EDGE}; class Callback { + public: + virtual ~Callback() {} protected: virtual void start() {} virtual void risingEdge() {} diff --git a/common/sip/Timer.sip b/common/sip/Timer.sip index c28f5fcdb..4f1d1b803 100644 --- a/common/sip/Timer.sip +++ b/common/sip/Timer.sip @@ -31,6 +31,8 @@ public: enum Stat {DOWN,UP,RISING_EDGE,FALLING_EDGE}; class Callback { + public: + virtual ~Callback(); protected: virtual void start(); virtual void risingEdge(); -- GitLab