Skip to content

GitLab

Closed
Created by Perceval Guillou@pguillouMaintainer

"InvalidValue: Roi out of limits" when applying rotation with an image_roi already defined

If a rotation of 90deg is set while a roi is already defined, then Lima tries to recompute the roi but then it checks that the new roi is included in the fullframe rect but it forgets to rotate the fullframe sizes.

example: if rot = 0 => camera fullsize: w=800, h=600

     + set a roi  => proxy.image_roi = 300,50,450,300

then we apply a rotation: proxy.image_rotation = '90' => lima applies rotation and then compute a new_roi => 250,300,300,450 BUT it checks that new_roi is included in fullframe <800, 600> and fails because the new roi is off It should have checked that the new_roi is in the rotated fullframe <600, 800> !

InvalidValue: Roi out of limitsm_max_roi=<0,0>-<800x600>, roi=<250,300>-<300x450>

if current rotation is 90 or 270, limitsm_max_roi should return <0,0>-<600x800> instead of <0,0>-<800x600>

Edited by Samuel Debionne