Follow-up from "Formalize CtSaving::SaveContainer::Handler for parallel saving on multiple files"
The following discussions from !165 (closed) should be addressed:
-
@debionne started a discussion: (+1 comment) Shouldn't these be member functions of
Handle
?class Handle { public: virtual ~Handle() {} protected: Handle() : m_nb_frames(0) {} private: friend class SaveContainer; int m_nb_frames; virtual _open(const std::string& filename, std::ios_base::openmode flags) = 0; virtual void _close() = 0; virtual long _writeFile(Data& data, CtSaving::HeaderMap& aHeader, FileFormat) = 0; };
-
@debionne started a discussion: (+1 comment) graph LR frame_nr --> m_frame_params --> params --> m_params_handle --> handle
Isn't that two potentially expensive lookups?
-
@debionne started a discussion: long long finalHeaderLength = (length + 1023) & ~1023; // 1024 alignment
Typo, lenght -> length
-
@debionne started a discussion: Related to my other suggestion bellow, shouldn't we call
close
here? -
@debionne started a discussion: (+1 comment) How about using
AutoPtr<Handle>
?typedef std::map<CtSaving::Parameters, AutoPtr<Handle>, cmpParameters> Params2Handle;