Lima issueshttps://gitlab.esrf.fr/limagroup/lima/-/issues2019-07-05T16:34:36+02:00https://gitlab.esrf.fr/limagroup/lima/-/issues/90Add README.md to cameras2019-07-05T16:34:36+02:00Samuel DebionneAdd README.md to camerasv1.8Laurent ClaustreLaurent Claustrehttps://gitlab.esrf.fr/limagroup/lima/-/issues/89Segfault if exiting python script while an acquisition is running2019-02-07T16:20:59+01:00Samuel DebionneSegfault if exiting python script while an acquisition is runningThis is a borderline use case, but segfaulting is a pretty bad behavior to!
```python
from Lima import Core, Simulator
cam = Simulator.Camera()
hw = Simulator.Interface(cam)
ct = Core.CtControl(hw)
ct.prepareAcq()
ct.startAcq()
```This is a borderline use case, but segfaulting is a pretty bad behavior to!
```python
from Lima import Core, Simulator
cam = Simulator.Camera()
hw = Simulator.Interface(cam)
ct = Core.CtControl(hw)
ct.prepareAcq()
ct.startAcq()
```v1.8https://gitlab.esrf.fr/limagroup/lima/-/issues/88New buffer subsystem API blocks Meta plugin to be built2019-02-08T14:25:30+01:00Alejandro Homs PuronNew buffer subsystem API blocks Meta plugin to be builtThe default copy constructor of the `BufferAllocMgr` has been deleted in !63. `Meta::Interface` default copy constructor becomes ill-formed. `SIP` wrapping attempts to implement the copy mechanism and failsThe default copy constructor of the `BufferAllocMgr` has been deleted in !63. `Meta::Interface` default copy constructor becomes ill-formed. `SIP` wrapping attempts to implement the copy mechanism and failsv1.8Samuel DebionneSamuel Debionnehttps://gitlab.esrf.fr/limagroup/lima/-/issues/87Simulator and Meta submodule references are lost2019-01-28T09:54:42+01:00Alejandro Homs PuronSimulator and Meta submodule references are lostCommit 7c88baca, merging contributions from GitHub, has deleted references to `camera/simulator` and `camera/common/meta` submodulesCommit 7c88baca, merging contributions from GitHub, has deleted references to `camera/simulator` and `camera/common/meta` submodulesv1.8Samuel DebionneSamuel Debionnehttps://gitlab.esrf.fr/limagroup/lima/-/issues/86Add camera meta2019-01-16T11:38:15+01:00Samuel DebionneAdd camera metav1.8Laurent ClaustreLaurent Claustrehttps://gitlab.esrf.fr/limagroup/lima/-/issues/83statistics saving2018-12-19T14:09:40+01:00Laurent Claustrestatistics savingEmmanuel Papillon did code a way of saving the CtSaving-compression statistics into files.
We should merge and improve this code.Emmanuel Papillon did code a way of saving the CtSaving-compression statistics into files.
We should merge and improve this code.v1.8Samuel DebionneSamuel Debionnehttps://gitlab.esrf.fr/limagroup/lima/-/issues/82[CMake] Rename CAMERA_ENABLE_PYTHON for every migrated cameras2019-01-09T19:40:10+01:00Samuel Debionne[CMake] Rename CAMERA_ENABLE_PYTHON for every migrated camerasShould be LIMA_ENABLE_PYTHON. Was my mistake in the first place to use a different variable name.Should be LIMA_ENABLE_PYTHON. Was my mistake in the first place to use a different variable name.v1.8Samuel DebionneSamuel Debionnehttps://gitlab.esrf.fr/limagroup/lima/-/issues/81In build library wrong versionning2018-12-21T09:44:51+01:00Laurent ClaustreIn build library wrong versionninglrwxrwxrwx 1 claustre soft 20 Oct 19 17:53 liblimabasler.so -> liblimabasler.so.1.8
-rwxr-xr-x 1 claustre soft 2819312 Oct 19 17:53 liblimabasler.so.
lrwxrwxrwx 1 claustre soft 17 Oct 19 17:53 liblimabasler.so.1.8 -> liblima...lrwxrwxrwx 1 claustre soft 20 Oct 19 17:53 liblimabasler.so -> liblimabasler.so.1.8
-rwxr-xr-x 1 claustre soft 2819312 Oct 19 17:53 liblimabasler.so.
lrwxrwxrwx 1 claustre soft 17 Oct 19 17:53 liblimabasler.so.1.8 -> liblimabasler.so.v1.8Samuel DebionneSamuel Debionnehttps://gitlab.esrf.fr/limagroup/lima/-/issues/69Remove LiveViewer plugin2019-09-16T11:23:31+02:00Samuel DebionneRemove LiveViewer pluginKnown to be a source of issues according to @sebastien.petitdemangeKnown to be a source of issues according to @sebastien.petitdemangev1.8Laurent ClaustreLaurent Claustrehttps://gitlab.esrf.fr/limagroup/lima/-/issues/61Reconfiguring with boostrap.py (running it a second time with different optio...2019-01-14T17:16:39+01:00Samuel DebionneReconfiguring with boostrap.py (running it a second time with different options) does not work as expectedDeleting the `build` folder before running `boostrap.py` was a bad idea since a lot of effort could have been put in configuring the project (especially on Windows). But now the `CMakeCache.txt` stays between to runs of `boostrap.py`.
If...Deleting the `build` folder before running `boostrap.py` was a bad idea since a lot of effort could have been put in configuring the project (especially on Windows). But now the `CMakeCache.txt` stays between to runs of `boostrap.py`.
If one enable a camera in the first run and then disable it in the second run, the camera stay enabled. `boostrap.py` should set the camera that was given on the command line to `ON` but all the other ones to `OFF`. For exemple:
```
./install.sh simulator
```
should generate
```
cmake ... -DLIMA_CAMERA_SIMULATOR=1 -DLIMA_CAMERA_RAYONIXHS=0 -DLIMA_CAMERA_BASLER=0 ...
```
Similar issue with git, e.g. reconfiguring with new cameras or options will not init/update their submodules.
Ultimate question, is this wrapper necessary? I build and install the conda packages with these two lines:
```
cmake -Bbuild -H. -DCMAKE_INSTALL_PREFIX=$PREFIX -DPYTHON_SITE_PACKAGES_DIR=$SP_DIR -DCMAKE_FIND_ROOT_PATH=$PREFIX
cmake --build build --target install
```
See https://github.com/esrf-bliss/Lima/issues/71#issuecomment-407371593 for the context.v1.8Alejandro Homs PuronAlejandro Homs Puronhttps://gitlab.esrf.fr/limagroup/lima/-/issues/59hdf5 ultimate changes2018-08-06T12:11:02+02:00Laurent Claustrehdf5 ultimate changesfinally after test on ID02 we decide to update once again the h5 format for lima.finally after test on ID02 we decide to update once again the h5 format for lima.v1.8Laurent ClaustreLaurent Claustrehttps://gitlab.esrf.fr/limagroup/lima/-/issues/55Install headers2018-08-06T12:11:02+02:00Samuel DebionneInstall headersHeader files are not installed when running `cmake --target install` (or `make install`) which makes the C++ API unusable.Header files are not installed when running `cmake --target install` (or `make install`) which makes the C++ API unusable.v1.8Samuel DebionneSamuel Debionnehttps://gitlab.esrf.fr/limagroup/lima/-/issues/46H5::Exception member function printError() is deprecated in 1.8.20 and 1.10.22018-05-22T12:03:52+02:00Samuel DebionneH5::Exception member function printError() is deprecated in 1.8.20 and 1.10.2Lima failed to build with recent version of HDF5 Cpp library.
```
CtSaving_Hdf5.cpp:670:10: error: 'class H5::DataSetIException' has no member named 'printError';
```Lima failed to build with recent version of HDF5 Cpp library.
```
CtSaving_Hdf5.cpp:670:10: error: 'class H5::DataSetIException' has no member named 'printError';
```v1.8Samuel DebionneSamuel Debionnehttps://gitlab.esrf.fr/limagroup/lima/-/issues/44HDF52018-07-12T11:09:43+02:00Laurent ClaustreHDF5* Use FindHdf5 in CMakeLists.txt
* fix for hard-coded instrument name* Use FindHdf5 in CMakeLists.txt
* fix for hard-coded instrument namev1.8Laurent ClaustreLaurent Claustrehttps://gitlab.esrf.fr/limagroup/lima/-/issues/43With RoiCounter processing without Rois, CtControl get stuck in AcqRunning st...2018-05-03T17:36:57+02:00Samuel DebionneWith RoiCounter processing without Rois, CtControl get stuck in AcqRunning status```c++
Camera simu;
Interface hw(simu);
CtControl ct(&hw);
// Setup a roi counter
Roi roi = Roi(0, 0, 100, 100);
lima::SoftOpExternalMgr *ext = ct.externalOperation();
SoftOpInstance roi_cnt_op_inst;
ext->addOp(ROICOUNTERS, "RoiCounter...```c++
Camera simu;
Interface hw(simu);
CtControl ct(&hw);
// Setup a roi counter
Roi roi = Roi(0, 0, 100, 100);
lima::SoftOpExternalMgr *ext = ct.externalOperation();
SoftOpInstance roi_cnt_op_inst;
ext->addOp(ROICOUNTERS, "RoiCounters", 0, roi_cnt_op_inst);
SoftOpBaseClass *p = roi_cnt_op_inst.m_opt;
SoftOpRoiCounter *roi_cnt_op = static_cast<SoftOpRoiCounter *>(p);
CtAcquisition *acq= ct.acquisition();
acq->setAcqMode(Single);
acq->setAcqExpoTime(expo);
acq->setAcqNbFrames(nframe);
ct.prepareAcq();
ct.startAcq();
std::cout << "SIMUTEST: acq started" << std::endl;
// Pool status
CtControl::Status status;
do
{
ct.getStatus(status);
} while (status.AcquisitionStatus != AcqStatus::AcqReady);
std::cout << "SIMUTEST: acq finished" << std::endl;
ct.stopAcq();
std::cout << "SIMUTEST: acq stopped" << std::endl;
```
In `_calcAcqStatus`, the following condition is always false because LastCounterReady is never incremented.
```
(!m_op_ext_sink_task_active ||anImageCnt.LastCounterReady == anImageCnt.LastImageAcquired)
```
_LastCounterReadyCallback is never called.v1.8Samuel DebionneSamuel Debionnehttps://gitlab.esrf.fr/limagroup/lima/-/issues/40CmdThread do SegFault in destructor2018-04-13T10:43:56+02:00Samuel DebionneCmdThread do SegFault in destructorThis is not duplicate of !53. The `AuxThread m_thread;` should be destroyed first.This is not duplicate of !53. The `AuxThread m_thread;` should be destroyed first.v1.8Samuel DebionneSamuel Debionnehttps://gitlab.esrf.fr/limagroup/lima/-/issues/37Add missing tests of simulator on Windows2018-05-03T17:36:57+02:00Samuel DebionneAdd missing tests of simulator on WindowsSome tests are not run on Windows because they do not compile.Some tests are not run on Windows because they do not compile.v1.8Samuel DebionneSamuel Debionnehttps://gitlab.esrf.fr/limagroup/lima/-/issues/36[XH] Add documentation of camera initialization and capabilities2021-11-08T13:25:47+01:00Samuel Debionne[XH] Add documentation of camera initialization and capabilitiesv1.8https://gitlab.esrf.fr/limagroup/lima/-/issues/35[Pixirad] Add documentation for capabilities2021-11-08T13:25:59+01:00Samuel Debionne[Pixirad] Add documentation for capabilitiesv1.8https://gitlab.esrf.fr/limagroup/lima/-/issues/34[CI] Add support for python 3 testing2018-04-10T14:16:59+02:00Samuel Debionne[CI] Add support for python 3 testingv1.8Samuel DebionneSamuel Debionne