doi-landing-page issueshttps://gitlab.esrf.fr/icat/doi-landing-page/-/issues2024-03-25T16:30:35+01:00https://gitlab.esrf.fr/icat/doi-landing-page/-/issues/103Fix lint job2024-03-25T16:30:35+01:00Marjolaine BodinFix lint jobThe linter failed, but the job is successful:
https://gitlab.esrf.fr/icat/doi-landing-page/-/jobs/1006983The linter failed, but the job is successful:
https://gitlab.esrf.fr/icat/doi-landing-page/-/jobs/1006983Marjolaine BodinMarjolaine Bodinhttps://gitlab.esrf.fr/icat/doi-landing-page/-/issues/102Add publish in CI2024-03-07T11:00:45+01:00Marjolaine BodinAdd publish in CIPublish on new version via the CI, as it is done in https://gitlab.esrf.fr/icat/icat-plus-api-ts
(maybe with the creation of a tag)Publish on new version via the CI, as it is done in https://gitlab.esrf.fr/icat/icat-plus-api-ts
(maybe with the creation of a tag)https://gitlab.esrf.fr/icat/doi-landing-page/-/issues/101Use icat-plus-api-ts2024-03-28T11:10:23+01:00Marjolaine BodinUse icat-plus-api-tsMarjolaine BodinMarjolaine Bodinhttps://gitlab.esrf.fr/icat/doi-landing-page/-/issues/100orcid link2024-03-06T10:55:18+01:00Marjolaine Bodinorcid linkFrom dataCite, we received the complete url of the orcid. https://data.esrf.fr/doi/10.15151/ESRF-DC-1534175008
Link to be updated, linked to https://data.esrf.fr/doi/10.15151/ESRF-DC-1534175008From dataCite, we received the complete url of the orcid. https://data.esrf.fr/doi/10.15151/ESRF-DC-1534175008
Link to be updated, linked to https://data.esrf.fr/doi/10.15151/ESRF-DC-1534175008Marjolaine BodinMarjolaine Bodinhttps://gitlab.esrf.fr/icat/doi-landing-page/-/issues/99Improve experimental report in DOI landing page2024-03-15T13:13:28+01:00Marjolaine BodinImprove experimental report in DOI landing pagecf. https://requests.esrf.fr/browse/DPT-115cf. https://requests.esrf.fr/browse/DPT-115Marjolaine BodinMarjolaine Bodinhttps://gitlab.esrf.fr/icat/doi-landing-page/-/issues/98Improve abstract display landing page2024-03-06T08:23:07+01:00Marjolaine BodinImprove abstract display landing pagehttps://data.esrf.fr/doi/10.15151/ESRF-DC-1534175008https://data.esrf.fr/doi/10.15151/ESRF-DC-1534175008Marjolaine BodinMarjolaine Bodinhttps://gitlab.esrf.fr/icat/doi-landing-page/-/issues/97Implement new landing page2023-11-06T16:46:59+01:00Mael GaonachImplement new landing page- Landing page for a doi
- Component to display DOI info that should be published and re-usable- Landing page for a doi
- Component to display DOI info that should be published and re-usablehttps://gitlab.esrf.fr/icat/doi-landing-page/-/issues/96Display the orcid2022-11-30T10:37:30+01:00Marjolaine BodinDisplay the orcidIf the orcid exists for a user (author or contributor), we can display it.If the orcid exists for a user (author or contributor), we can display it.ORCIDMarjolaine BodinMarjolaine Bodinhttps://gitlab.esrf.fr/icat/doi-landing-page/-/issues/95Access data under embargo2024-02-21T17:08:04+01:00Marjolaine BodinAccess data under embargoIf data are under embargo, add a lock icon to the button `Access data`, or change the text by `Access data for experimental team`If data are under embargo, add a lock icon to the button `Access data`, or change the text by `Access data for experimental team`Marjolaine BodinMarjolaine Bodinhttps://gitlab.esrf.fr/icat/doi-landing-page/-/issues/94Experimental report: fix server config2022-03-22T13:53:08+01:00Marjolaine BodinExperimental report: fix server configReplace
- `https://wwws.esrf.fr/misapps/SMISServer/rest/reports/fileNames` by `https://smis.esrf.fr/misapps/SMISServer/rest/reports/fileNames`
- `ftp://www.esrf.eu/pub/UserReports/` by `http://ftp.esrf.fr/pub/UserReports/`Replace
- `https://wwws.esrf.fr/misapps/SMISServer/rest/reports/fileNames` by `https://smis.esrf.fr/misapps/SMISServer/rest/reports/fileNames`
- `ftp://www.esrf.eu/pub/UserReports/` by `http://ftp.esrf.fr/pub/UserReports/`Marjolaine BodinMarjolaine Bodinhttps://gitlab.esrf.fr/icat/doi-landing-page/-/issues/93Citation2024-02-21T17:08:12+01:00Marjolaine BodinCitationThe citation must contain the link to `https://doi.org/xxxxx` and not to `https://doi.esrf.fr/`, if we follow the APA style (https://apastyle.apa.org/style-grammar-guidelines/references/dois-urls). It could be badly detected in crossref....The citation must contain the link to `https://doi.org/xxxxx` and not to `https://doi.esrf.fr/`, if we follow the APA style (https://apastyle.apa.org/style-grammar-guidelines/references/dois-urls). It could be badly detected in crossref.
Example from Renaud:
```
Svensson, O., Gilski, M., Nurizzo, D. & Bowler, M. W. (2019). A
Catalogue Of Characteristics From All Samples Processed On The
Fully Autonomous ESRF Beamline MASSIF-1 Between 2014 And
2018. https://doi.esrf.fr/10.15151/ESRF-DC-186715792
http://api.crossref.org/works/10.1107/S2052252519008017 => badly detected in crossref
{
"key": "fs5175_bb66",
"unstructured": "Svensson, O., Gilski, M., Nurizzo, D. & Bowler, M. W. (2019). A Catalogue Of Characteristics From All Samples Processed On The Fully Autonomous ESRF Beamline MASSIF-1 Between 2014 And 2018. https://doi.esrf.fr/10.15151/ESRF-DC-186715792."
},
```
See if we could use the datacite formatter
https://datacite.org/citation.htmlMarjolaine BodinMarjolaine Bodinhttps://gitlab.esrf.fr/icat/doi-landing-page/-/issues/92Mention of citation2024-02-21T17:08:19+01:00Alejandro De Maria AntolinosMention of citationReported by @dimper the landing page should mention that the the use of the data implies citing the original authors as written in the data policy.
`Researchers must acknowledge the source of the data and cite its unique identifier as we...Reported by @dimper the landing page should mention that the the use of the data implies citing the original authors as written in the data policy.
`Researchers must acknowledge the source of the data and cite its unique identifier as well as any publications linked to the same raw data.
`
This is needed by the CTSMarjolaine BodinMarjolaine Bodinhttps://gitlab.esrf.fr/icat/doi-landing-page/-/issues/91Replace citation by reference2021-06-15T10:48:30+02:00Marjolaine BodinReplace citation by referenceSee [data working group meeting](https://confluence.esrf.fr/display/DATAWGWK/Data++working+group+Meeting+notes-2021)See [data working group meeting](https://confluence.esrf.fr/display/DATAWGWK/Data++working+group+Meeting+notes-2021)https://gitlab.esrf.fr/icat/doi-landing-page/-/issues/90Display Contributors and replace citation by reference2021-09-06T15:28:58+02:00Marjolaine BodinDisplay Contributors and replace citation by referenceThe list of authors must be changed by including only Users (in alphabetical order) from the AForm. The local contacts are Contributors, and the list of Contributors should be displayed on the landing page
See https://gitlab.esrf.fr/i...The list of authors must be changed by including only Users (in alphabetical order) from the AForm. The local contacts are Contributors, and the list of Contributors should be displayed on the landing page
See https://gitlab.esrf.fr/icat/icat-ingester/-/issues/11 and [data working group meeting](https://confluence.esrf.fr/display/DATAWGWK/Data++working+group+Meeting+notes-2021)
Expected:
- display the list of contributors
- Replace citation by referenceMarjolaine BodinMarjolaine Bodinhttps://gitlab.esrf.fr/icat/doi-landing-page/-/issues/89Access data button available for restricted data2021-04-08T09:11:11+02:00Marjolaine BodinAccess data button available for restricted dataExample: https://doi.esrf.fr/10.15151/ESRF-ES-404440984
with ` publicationYear=2024`
![doiPage](/uploads/0d646a7738cd802b2c9fcaef078c8e8b/doiPage.PNG)
Probably `getAccessibilityStatus` should return `"Open access"` instead of `"...Example: https://doi.esrf.fr/10.15151/ESRF-ES-404440984
with ` publicationYear=2024`
![doiPage](/uploads/0d646a7738cd802b2c9fcaef078c8e8b/doiPage.PNG)
Probably `getAccessibilityStatus` should return `"Open access"` instead of `"Restricted access"`. It could be due to wrong `publiclyAvailableDate` or wrong `resourceType`https://gitlab.esrf.fr/icat/doi-landing-page/-/issues/88Message about data are under embargo even if data is open2021-01-06T10:47:45+01:00Alejandro De Maria AntolinosMessage about data are under embargo even if data is openWhen an investigation is released (released date is changed) the page displays that the data are still under embargo
![image](/uploads/62d177d140d52e42dcc6d37abe42cacf/image.png)
This happens because by default the page is taking the pu...When an investigation is released (released date is changed) the page displays that the data are still under embargo
![image](/uploads/62d177d140d52e42dcc6d37abe42cacf/image.png)
This happens because by default the page is taking the publication year from datacite then it is not aware if the released date is changed in ICAThttps://gitlab.esrf.fr/icat/doi-landing-page/-/issues/87Do we need bower + npm ?2024-02-21T17:08:26+01:00Maxime ChailletDo we need bower + npm ?This project uses bower + npm package managers.
The dependencies added by bower are:
```
"jquery": "^3.2.1",
"dustjs-linkedin": "^2.7.5",
"bootstrap": "^4.0.0",
"dustjs-helpers": "^1.7.3",
"lodash": "^4.17.5",
"momen...This project uses bower + npm package managers.
The dependencies added by bower are:
```
"jquery": "^3.2.1",
"dustjs-linkedin": "^2.7.5",
"bootstrap": "^4.0.0",
"dustjs-helpers": "^1.7.3",
"lodash": "^4.17.5",
"moment": "momentjs#^2.21.0"
```
They could be managed by npm instead, and then we could drop bower.
On top of that, bower's maintainers recommend to drop it and use another one instead (yarn)https://gitlab.esrf.fr/icat/doi-landing-page/-/issues/86Use a formater for the code2024-02-21T17:08:32+01:00Maxime ChailletUse a formater for the codeA formater is needed for this project. This will enable nicer MR since only the relevantly modified lines will show up. The idea is to be simple by using the same config as for other projects.such as EDataportal.
Chosen formater : prett...A formater is needed for this project. This will enable nicer MR since only the relevantly modified lines will show up. The idea is to be simple by using the same config as for other projects.such as EDataportal.
Chosen formater : prettier
To do:
- create a configuration file for prettier
- create a script in package.json to start the checking of the code style
- write documentation for the devs about how to format the apphttps://gitlab.esrf.fr/icat/doi-landing-page/-/issues/85Add a test related to link in template page #842024-02-21T17:08:48+01:00Maxime ChailletAdd a test related to link in template page #84related to #84related to #84https://gitlab.esrf.fr/icat/doi-landing-page/-/issues/84on the welcome page, the link to get all the DOI generated at ESRF does not work2020-11-20T23:07:59+01:00Maxime Chailleton the welcome page, the link to get all the DOI generated at ESRF does not workClicking on the link below
![image](/uploads/5e03c4348b9e7550efdaf95922e701a4/image.png)
renders the following
![image](/uploads/3e57bb29cf87ee6889ea789aae32235a/image.png)Clicking on the link below
![image](/uploads/5e03c4348b9e7550efdaf95922e701a4/image.png)
renders the following
![image](/uploads/3e57bb29cf87ee6889ea789aae32235a/image.png)Maxime ChailletMaxime Chaillet