Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D Datahub
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 50
    • Issues 50
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ICAT
  • Datahub
  • Merge requests
  • !411

Merged
Created Aug 21, 2020 by Axel Bocciarelli@bocciareMaintainer

Populate addresses drop-downs with default shipping and return addresses if not already present

  • Overview 3
  • Commits 2
  • Pipelines 1
  • Changes 2

Let's assume that both users A and B are participants in an investigation called ID0.

  • User A creates an address and selects it as the default shipping address for ID0.
  • User B goes to edit the shipping configuration of ID0 ➡ the drop-down menu for the default shipping address is blank because User B does not have access to the address created by User A.

This MR resolves this situation by populating the drop-down menus with the addresses from the shipment, if and only if the user does not have access to these addresses (to avoid duplicates).

This morning's events also changed my mind in regard to disabling the drop-downs when they contain no addresses. Turns out I found it quite frustrating not being able to open the drop-downs even though I knew they were empty...

Edited Aug 21, 2020 by Axel Bocciarelli
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix