Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Datahub Datahub
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 62
    • Issues 62
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ICAT
  • DatahubDatahub
  • Merge requests
  • !259

Add and display addresses

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Loic Huder requested to merge 255-shipping-address-management into SampleTracking Jun 19, 2020
  • Overview 17
  • Commits 3
  • Pipelines 9
  • Changes 14
  • Adds a tab "Manage Adresses" that displays all addresses of a user image
  • Adds a form to add a new address to a proposal. The form is validated using react-hook-form capabilities. image

This MR is to discuss first the implementation of these basic functionalities before the full-fledged implementation of #255 (closed).

Points I would like to discuss:

  • Integration in the UI and layout in general

Used app__inner as suggested by @bocciare

  • Use of Redux ? I didn't use Redux state at all so I will be happy to have any pointers on that.

Done.

  • Request implementations. I put them in a dedicated api.js file but you might want to add the URI to your "catalogue".

Added to api/icatPlus.js

  • Author/CreatedBy field. Is this needed ? If yes, how can I get the name from the user id ?

Hidden for now

  • New routes. I put the form at addresses/new and the address table at addresses/. Is this fine by you ?

Same pattern as shipments

Edited Jun 23, 2020 by Loic Huder
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 255-shipping-address-management