It would be helpful for each update of XRSTools here to use a git tag pushed to gitlab.esrf.fr - there are no git tags yet.
Debian can use such git tags to show when new releases / git tags are made.
I'd suggest a git tag named 0.16
for the 0.16 release, v0.16
would also work.
Thanks.
In Debian, we have a process to test the build of all packages so that a repeat build produces identical binaries. https://reproducible-builds.org/
xrstools is failing these tests, primarily because the source code uses code like:
os.path.join(os.path.dirname(os.path.abspath(__file__)),
in multiple locations.
I am currently having to patch each of these to refer to a single basepath matching the final installation directory for the package:
/usr/lib/python3/dist-packages/XRStools/resources/
It would be useful if XRSTools could set the expected base path once and then pick up that path each time it needs to set such a path. Then Debian would be able to set an alternative in just one place.
Current patch: https://salsa.debian.org/science-team/xrstools/-/blob/master/debian/patches/reproducible_build.patch
This patch isn't usable upstream directly, however, there are other locations within the codebase where reference is made to __file__
to build paths. It would be useful if all such occurrences used a single configurable base path instead of trying to use __file__
.
See also: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000326
The wizard had to be disabled in the upload to Debian because PyQt4 was replaced by PyQt5 after Debian 8, Jessie, released on April 26th, 2015. All current releases have PyQt5. https://tracker.debian.org/pkg/pyqt5
A simple test to change the imports from PyQt4 to PyQt5 was insufficient, there will need to be code changes in the Qt handling to work with Qt5.
For now, Debian removes the wizard using this patch: https://salsa.debian.org/science-team/xrstools/-/blob/master/debian/patches/remove_xrs_wizard_pyqt4.patch
Would it be possible to migrate the Python3 support (currently on the mac branch) to support PyQt5?
Created at https://salsa.debian.org/science-team/xrstools/-/blob/master/debian/patches/fix_python_syntax_error.patch for Debian packaging of the mac branch using Python3. Prior to this change, installation raised syntax errors.
Neil Williams (ae526d95) at 07 Oct 15:29
Fix syntax error seen during installation
... and 17 more commits