CI does not work properly
Despite !1687 (merged) some more work needs to be done on CI.
Current problems:
-
merge_request
detached pipeline succeeds and makes the MR mergeable even if black job fails -
run_tests
job run twice when you push to a branch that has an opened merge request
The later is caused by a limitation of gitlab-ci and could be resolved in 4 ways:
- abandon
run_tests
for branch push, keeping it only for master and merge requests - add some trickery to cancel branch push jobs when this branch has an opened MR
- wait for gitlab-ci to provide desired feature (*)
- Do not rely on gitlab-ci to detect changes and do the check ourselves
Guess I will give the second option a go
First option seems acceptable and keeps things simple
(*) For the record, some useful links to gitlab issues:
- https://gitlab.com/gitlab-org/gitlab/issues/16733
- https://gitlab.com/gitlab-org/gitlab-foss/issues/19232
- https://gitlab.com/gitlab-org/gitlab-foss/issues/37397
- https://gitlab.com/gitlab-org/gitlab/issues/15266
- https://gitlab.com/gitlab-org/gitlab/issues/29654
- https://gitlab.com/gitlab-org/gitlab/issues/22638
- https://gitlab.com/gitlab-org/gitlab-foss/issues/56632
- https://gitlab.com/gitlab-org/gitlab/issues/20803