Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • bliss bliss
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 544
    • Issues 544
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 145
    • Merge requests 145
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • BlissBliss
  • blissbliss
  • Merge requests
  • !4636

Clean up edit_roi plot creation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Valentin Valls requested to merge fix-lima-pattern into master May 06, 2022
  • Overview 0
  • Commits 2
  • Pipelines 2
  • Changes 3

Closes #3350 (closed)

This PR make sure an image is displayed during the edit_rois request.

  • get_live_plot was now always returning a plot, so part of the code was outdated
  • But an ugly except Exception was catching an unrelated error which is why it was working sometimes

Both was cleaned up.

This changes can be backported to 1.10.x

Edited May 06, 2022 by Valentin Valls
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-lima-pattern