Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • bliss bliss
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 548
    • Issues 548
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 151
    • Merge requests 151
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • BlissBliss
  • blissbliss
  • Merge requests
  • !3660

Add device metadata to scan_info

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Valentin Valls requested to merge valentin.valls/bliss:add-device-meta-to-scan_info2 into master Apr 23, 2021
  • Overview 8
  • Commits 17
  • Pipelines 9
  • Changes 16

Closes #2705 (closed)

This MR is about to provide metadata per device to the scan_info.

For now it will only provide basic types for few devices:

  • Lima
  • MCAs
scan_info = {
    ...
    "devices": {
        "1001:mca1" {
            "type":"mca" 
            "channels": [...]
        }
        "1002:lima1" {
            "type":"lima" 
            "channels": [...]
        }
    }
}

With that we now can follow this implicit rules:

"mca" device type
└── channel 1D are spectra

"lima" device type
├── There is a single channel 1D, that's the image detector (we can't assume its name cause of the alias)
├── "bpm" device name
|   └── there is probably something to say here 
├── "roi_counters" device name
|   └── channels are ROIs
├── "roi_profiles" device name
|   └── channels are profile ROIs
└── "roi_collection" device name
    └── there is probably something to say here

Todo

  • How to retrieve the metadata?
    • device.get_metadata()?
    • acq_obj.fill_meta()?
      • fill_meta_at_scan_start (which is meta after prepare)
      • fill_meta_at_scan_end (which is meta after the scan)
    • I would be happy to have meta at start of the scan + plus meta after prepare
  • When to retrieve the metatdata?
  • Update the documentation
  • Update the changelog
Edited May 10, 2021 by Valentin Valls
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: add-device-meta-to-scan_info2